Skip to content

[Metadata Composite Keys] Update set_primary_key docstring#2841

Open
pvk-developer wants to merge 3 commits intofeature/metadata-composite-keysfrom
issue-2824-update-set_primary_key-docstring-in-metadata
Open

[Metadata Composite Keys] Update set_primary_key docstring#2841
pvk-developer wants to merge 3 commits intofeature/metadata-composite-keysfrom
issue-2824-update-set_primary_key-docstring-in-metadata

Conversation

@pvk-developer
Copy link
Member

@pvk-developer pvk-developer commented Mar 11, 2026

Resolves #2824
CU-86b8n8h1r

@sdv-team
Copy link
Contributor

sdv-team commented Mar 11, 2026

Task linked: CU-86b8n8h1r SDV - [Metadata composite keys] Update set_primary_key docstring to indicate a list of columns is now valid #2824

@pvk-developer pvk-developer marked this pull request as ready for review March 11, 2026 17:07
@pvk-developer pvk-developer requested a review from a team as a code owner March 11, 2026 17:07
@pvk-developer pvk-developer requested review from frances-h and removed request for a team March 11, 2026 17:07
@pvk-developer pvk-developer requested a review from fealho March 11, 2026 17:07
@codecov
Copy link

codecov bot commented Mar 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (d7b8b4c) to head (61337c0).
⚠️ Report is 1 commits behind head on feature/metadata-composite-keys.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##           feature/metadata-composite-keys    #2841   +/-   ##
================================================================
  Coverage                            98.06%   98.06%           
================================================================
  Files                                   73       73           
  Lines                                 8278     8278           
================================================================
  Hits                                  8118     8118           
  Misses                                 160      160
Flag Coverage Δ
integration 75.62% <ø> (ø)
unit 97.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fealho
fealho reviewed Mar 11, 2026
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue also asks to "update the docstring for SingleTableMetadata.set_primary_key".

@sdv-team
Copy link
Contributor

sdv-team commented Mar 11, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@pvk-developer pvk-developer force-pushed the feature/metadata-composite-keys branch from 868be4d to d7b8b4c Compare March 12, 2026 14:10
@pvk-developer pvk-developer force-pushed the issue-2824-update-set_primary_key-docstring-in-metadata branch from 76a0fec to 682dc82 Compare March 12, 2026 15:15
@sdv-team
Copy link
Contributor

sdv-team commented Mar 12, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@sdv-team
Copy link
Contributor

sdv-team commented Mar 12, 2026

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@pvk-developer pvk-developer requested a review from R-Palazzo March 12, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fealho fealho fealho approved these changes

@frances-h frances-h Awaiting requested review from frances-h frances-h is a code owner automatically assigned from sdv-dev/core-contributors

@R-Palazzo R-Palazzo Awaiting requested review from R-Palazzo

Assignees

@pvk-developer pvk-developer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvk-developer @sdv-team @fealho